Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add connection check #209

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Feb 6, 2024

Summary

Added information in the HTML report if a vCenter Server authentication fails to be caught.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #146

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 6, 2024
@burnsjared0415 burnsjared0415 force-pushed the Bug-/error-message-handling-for-vCenter branch from b0b9fc1 to 6a04d26 Compare February 6, 2024 16:47
@tenthirtyam tenthirtyam self-requested a review February 6, 2024 17:33
@tenthirtyam tenthirtyam added this to the v2.6.1 milestone Feb 6, 2024
@burnsjared0415 burnsjared0415 force-pushed the Bug-/error-message-handling-for-vCenter branch from 6a04d26 to 4e55046 Compare February 6, 2024 17:36
@tenthirtyam tenthirtyam changed the title Bugfix: Address some Errors for vCenter fix: add connection check Feb 6, 2024
@tenthirtyam tenthirtyam added enhancement Enhancement and removed documentation Documentation needs-review Needs Review labels Feb 6, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review February 6, 2024 17:41
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 6, 2024 17:41
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 6, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
added information if a vCenter Authentication fails to be caught in the HTML report

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@burnsjared0415 burnsjared0415 force-pushed the Bug-/error-message-handling-for-vCenter branch from 4e55046 to 456eff6 Compare February 6, 2024 17:44
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 6, 2024
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenthirtyam tenthirtyam merged commit 4079cde into vmware:develop Feb 6, 2024
1 check passed
Copy link

github-actions bot commented Mar 8, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to show skipped or failed checks as warning / errors in the HTML report
2 participants