Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invoke prerequisites check #24

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Nov 22, 2022

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Removes the Test-VcfReportingPrereq from the Invoke-* cmdlets, blocking running the cmdlets.
  • Updates the README.md for prerequisites verification.
  • Updates the module to align to a minimum of PowerValidatedSolutions 1.7.0 to align with the current README.md.

Closes #26

Signed-off-by: Ryan Johnson johnsonryan@vmware.com

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

- Removes the `Test-VcfReportingPrereq` from the `Invoke-*` cmdlets.
- Updates the `README.md` for prerequisites verification.
- Updates the module to align to a minimum of PowerValidatedSolutions 1.7.0 to align with the current `README.md`.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added the bug Bug label Nov 22, 2022
@tenthirtyam tenthirtyam added this to the v1.0.5 milestone Nov 22, 2022
@tenthirtyam tenthirtyam requested a review from a team as a code owner November 22, 2022 17:24
@tenthirtyam tenthirtyam self-assigned this Nov 22, 2022
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaryJBlake GaryJBlake merged commit 7e237e5 into main Nov 23, 2022
@GaryJBlake GaryJBlake deleted the fix/remove-invoke-prerequisites-check branch November 23, 2022 08:24
@GaryJBlake
Copy link
Contributor

Closes #26

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Incorrect module version returns in Test-VcfReportingPrereq
2 participants