Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cpu cores per socket #85

Merged
merged 1 commit into from
Feb 3, 2023
Merged

feat: add cpu cores per socket #85

merged 1 commit into from
Feb 3, 2023

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Adds CPU Cores per Socket to the ESXi Host Overview on the overview report.

Signed-off-by: Ryan Johnson johnsonryan@vmware.com

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Related: #78 (Does not close.)

Test and Documentation Coverage

  • Tests have been completed (for bug fixes/features).
  • Documentation has been added/updated (for bug fixes/features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Adds CPU Cores per Socket to the ESXi Host Overview on the overview report.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added enhancement Enhancement report/overview Overview Report labels Feb 3, 2023
@tenthirtyam tenthirtyam added this to the v1.1.0 milestone Feb 3, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 3, 2023 15:42
@tenthirtyam tenthirtyam self-assigned this Feb 3, 2023
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit ed8191e into main Feb 3, 2023
@GaryJBlake GaryJBlake deleted the feat/cores-per-socket branch February 3, 2023 15:48
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement report/overview Overview Report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants