Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Fix in Developer Guide #256

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Fix in Developer Guide #256

merged 2 commits into from
Aug 20, 2019

Conversation

akashs2795
Copy link
Contributor

Changed the npm start command to run with proxy to disable cors checks
Fixes #254

Using npm run startdev to allow purser UI to communicate with backend behind proxy to avoid cross origin errors.

Changed the npm start command to run with proxy to disable cors checks
@vmwclabot
Copy link

@akashs2795, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@akashs2795
Copy link
Contributor Author

@hemani19 @kreddyj Can you guys please review ?

Change the run command to disable interactions by default in developer guide
@kreddyj kreddyj self-requested a review August 20, 2019 06:25
@kreddyj kreddyj added bug Something isn't working documetation Relates to documentation labels Aug 20, 2019
Copy link
Contributor

@kreddyj kreddyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kreddyj kreddyj merged commit dca914f into vmware-archive:master Aug 20, 2019
@vmwclabot
Copy link

@akashs2795, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

@vmwclabot
Copy link

@akashs2795, VMware has approved your signed contributor license agreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documetation Relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug : Developer guide
3 participants