Fix incompatibility with vcrpy 2 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeking3 Thanks for the fix. Will merge it once the vcr fix is merged. |
|
Upstream fix was merged, waiting for a new vcrpy release. |
|
@jeking3 , it looks like this needs a rebase. |
jeking3
force-pushed
the
issue-748-vcrpy-2
branch
from
e247a93
to
e6447ae
Compare
|
@tianhao64 all set, build passed |
|
ping @hartsock |
|
@pgbidkar are you around? |
Yes I am. Occupied with other priority tasks. Will look into it. Thanks |
|
The change looks fine to me. Currently tests will probably fail if executed because they were not updated after the major update for vSphere 8.0: a90023f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #748
Note this requires a new vcrpy release with kevin1024/vcrpy#415 in it.