Add vrf_transit_subnets to nsxt_policy_tier0_gateway (#1002) #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
2 similar comments
|
/test-all |
|
/test-all |
|
I think the part where this new attribute is set in schema is missing (in |
salv-orlando
force-pushed
the
issue1002
branch
from
eaa5f36
to
6d8886b
Compare
|
/test-all |
salv-orlando
force-pushed
the
issue1002
branch
from
6d8886b
to
e3125f0
Compare
|
/test-all |
|
@annakhm can you have another look, please? |
annakhm
reviewed
Nov 22, 2023
| @@ -109,6 +109,17 @@ func resourceNsxtPolicyTier0Gateway() *schema.Resource { | |||
| Computed: true, | |||
| ForceNew: true, // Modification of transit subnet not allowed after Tier-0 deployment | |||
| }, | |||
| "vrf_transit_subnets": { | |||
| Type: schema.TypeList, | |||
| MaxItems: 1, | |||
There was a problem hiding this comment.
I'm guessing we expect the API to allow more subnets in future (such as ipv6 support?)
In this case, I would remove the MaxItems here to allow native support for this in the future, and rely on NSX validation in the time being.
If we don't expect the list to grow, we should remove the list here as well, to avoid confusion.
The vrf_transit_subnets attribute is supported for NSX>=4.1.0. Signed-off-by: Salvatore Orlando <sorlando@vmware.com>
salv-orlando
force-pushed
the
issue1002
branch
from
e3125f0
to
bff29de
Compare
annakhm
approved these changes
Nov 24, 2023
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vrf_transit_subnets attribute is supported for NSX>=4.1.0.