-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vrf_transit_subnets to nsxt_policy_tier0_gateway (#1002) #1026
Conversation
/test-all |
2 similar comments
/test-all |
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the part where this new attribute is set in schema is missing (in |
eaa5f36
to
6d8886b
Compare
/test-all |
6d8886b
to
e3125f0
Compare
/test-all |
@annakhm can you have another look, please? |
@@ -109,6 +109,17 @@ func resourceNsxtPolicyTier0Gateway() *schema.Resource { | |||
Computed: true, | |||
ForceNew: true, // Modification of transit subnet not allowed after Tier-0 deployment | |||
}, | |||
"vrf_transit_subnets": { | |||
Type: schema.TypeList, | |||
MaxItems: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing we expect the API to allow more subnets in future (such as ipv6 support?)
In this case, I would remove the MaxItems
here to allow native support for this in the future, and rely on NSX validation in the time being.
If we don't expect the list to grow, we should remove the list here as well, to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
The vrf_transit_subnets attribute is supported for NSX>=4.1.0. Signed-off-by: Salvatore Orlando <sorlando@vmware.com>
e3125f0
to
bff29de
Compare
/test-all |
The vrf_transit_subnets attribute is supported for NSX>=4.1.0.