Add resource nsxt_ip_pool_allocation_ip_address #190
Conversation
ghost
added
|
Hi @MartinWeindel, thank you for this contribution and sorry for the delay. We will review in coming days. |
nsxt/utils_test.go
Outdated
| func getIpPoolName() string { | ||
| name := os.Getenv("NSXT_TEST_IP_POOL") | ||
| if name == "" { | ||
| name = ipPoolDefaultName |
There was a problem hiding this comment.
I don't think nsx provides default IP pool. We need to skip the test if pool is not provided for the test in the environment (otherwise test fails)
There was a problem hiding this comment.
Test is now skipped if NSXT_TEST_IP_POOL is not set
| }, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccNSXIpPoolAllocationIPAddressCreateTemplate(poolName), |
There was a problem hiding this comment.
I notice this test is failing with 409 (conflict) during create. Hope to provide more details on this later.
There was a problem hiding this comment.
I don't see this issue and have no clue about its cause. Please provide some suggestions how to deal with it.
There was a problem hiding this comment.
Thanks for the changes. 409 Conflict was due to my pool not having IP to allocate, so this is fine.
ignoring test TestAccResourceNsxtIPPoolAllocationIPAddress_basic if NSXT_TEST_IP_POOL not set, fixing lint spelling issues, reordered error handling
|
@annakhm: Thanks for the review and merging. BTW, will there be a release in the very near future? |
|
@MartinWeindel hopefully, we are working on it |
For allocating and releasing IP addresses from an IP pool, the resource
nsxt_ip_pool_allocation_ip_addressand the data sourcensxt_ip_poolhave been added.Acceptance tests and documentation have also been added. For the data source and the allocation tests, an existing IP pool is needed. A new environmental variable
NSXT_TEST_IP_POOLhas been defined to specify it.