Fix tag removal in vm tags resource #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to update tags to empty list, sdk expects empty slice, rather then nil slice, to be passed to update tags call. This way tags will not be omitted from API call. This doesn't affect general resources, since update function uses PUT Api which will wipe out tags if not passed.
ghost
added
the
asarfaty
approved these changes
Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to update tags to empty list, sdk expects empty slice,
rather then nil slice, to be passed to update tags call. This way
tags will not be omitted from API call.
This doesn't affect general resources, since update function
uses PUT Api which will wipe out tags if not passed.