Initialize VMC NSX version to 3.0.0 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This si required for version-dependant code paths. In future, we need to find a way to either find out underlying NSX version in VMC deployment, or maintain a mapping of VMC version to NSX version.
enhaocui
approved these changes
Dec 17, 2020
Some VMC customers might remain with NSX 2.5 for a while. Due to significant changes in support for NSX below and above 3.0.0, we need a way to distinguish between the two. Since version API is not accessible in VMC, we use search API which is not available before 3.0.0. In future, a more reliable way is to be introduces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This si required for version-dependant code paths.
In future, we need to find a way to either find out underlying
NSX version in VMC deployment, or maintain a mapping of VMC version
to NSX version.