Fix some issues with NAT #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@2ez4szliu, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
2ez4szliu
force-pushed
the
lshizhao/fix-nat
branch
from
8e8711a
to
24bd9ca
Compare
annakhm
reviewed
Jun 3, 2022
| @@ -345,8 +362,8 @@ func resourceNsxtPolicyNATRuleCreate(d *schema.ResourceData, m interface{}) erro | |||
| ruleStruct.TranslatedPorts = &ports | |||
| } | |||
|
|
|||
| if len(sNets) > 0 { | |||
| ruleStruct.SourceNetwork = &sNets | |||
| if sNets != nil && len(*sNets) > 0 { | |||
There was a problem hiding this comment.
I think since sNets would be nil unless specified, we can move it up into struct initialization, no need for this if (same below)
There was a problem hiding this comment.
Done. Also added a test case to test create NO_SNAT with no translated network
|
/test-all |
(1) When creating REFLEXIVE Nat rules, the destination_network should be set to nil instead of empty string (issue vmware#758) (2) Allow translated_network field to be optional when for no_snat/no_dnat (issue vmware#753) Signed-off-by: Shizhao Liu <lshizhao@vmware.com>
2ez4szliu
force-pushed
the
lshizhao/fix-nat
branch
from
24bd9ca
to
eb8c0f0
Compare
This was
linked to
issues
Jun 10, 2022
annakhm
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues with NAT
(1) When creating REFLEXIVE Nat rules, the destination_network should be set to nil instead of empty string (issue #758)
(2) Allow translated_network field to be optional for no_snat/no_dnat (issue #753)