Support locale_service Gateway clause for LM #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
This was
linked to
issues
Jun 15, 2022
2ez4szliu
reviewed
Jun 16, 2022
| if len(localeServices) > 0 { | ||
|
|
||
| if isGlobalManager { |
There was a problem hiding this comment.
nit: can we move this out of the if len(localeServices) > 0 block, like L933-938 of nsxt/resource_nsxt_policy_tier0_gateway.go
Today, locale service clause is only supported on Global Manager. This change allows to configure it for Local Manager as well. This configuration conflicts with edge_cluster_path and allows more flexibility. When importing Gateway, edge_cluster_path will be initialized rather than locale_service, and additional apply is required to switch to locale_service configuration. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
|
/test-all |
2ez4szliu
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, locale service clause is only supported on Global Manager.
This change allows to configure it for Local Manager as well. This
configuration conflicts with edge_cluster_path and allows more
flexibility.
When importing Gateway, edge_cluster_path will be initialized rather
than locale_service, and additional apply is required to switch to
locale_service configuration.
Signed-off-by: Anna Khmelnitsky akhmelnitsky@vmware.com