Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change detection in lb virtual server rules #774

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Jul 29, 2022

We should perform change based on change in any rule, as
opposed to looking only at rule count.
Signed-off-by: Anna Khmelnitsky akhmelnitsky@vmware.com

We should perform change based on change in any rule, as
opposed to looking only at rule count.
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
@annakhm annakhm requested a review from 2ez4szliu July 29, 2022 22:16
@annakhm
Copy link
Collaborator Author

annakhm commented Jul 29, 2022

/test-all

1 similar comment
@annakhm
Copy link
Collaborator Author

annakhm commented Aug 3, 2022

/test-all

@annakhm annakhm requested a review from ksamoray August 4, 2022 18:19
Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annakhm annakhm merged commit 8e4241b into master Aug 29, 2022
@annakhm annakhm deleted the fix-lb-rules branch August 29, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants