Fix mixup in condition to address lb rules #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A negation was missing in assesment of rule change, that relates to provider version upgrade workaround. When no change in rules is detected, we assume current rules should be preserved, for sake of rules that were added manually on NSX when rule feature was not present in proveder. In addition, fix inconsistent documentation. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
annakhm
force-pushed
the
fix-lb-rules-2
branch
from
2a24a60
to
d40fd5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A negation was missing in assesment of rule change, that relates to provider version upgrade workaround. When no change in rules is detected, we assume current rules should be preserved, for sake of rules that were added manually on NSX when rule feature was not present in proveder.
In addition, fix inconsistent documentation.
Signed-off-by: Anna Khmelnitsky akhmelnitsky@vmware.com