add security policy schema and resource with unit tests #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishangupta-ds
requested review from
shreyassreenivas,
Vasundharashukla and
shobha2626
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
from
f5cd7ba
to
84f2220
Compare
examples/resources/security_policy/resource_cluster_group_security_policy.tf
Outdated
Show resolved
Hide resolved
|
Can you break it into multiple logical commits |
Sure |
shreyassreenivas
previously approved these changes
Aug 5, 2022
internal/resources/policy/type/security/resource_security_policy.go
Outdated
Show resolved
Hide resolved
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
2 times, most recently
from
9d53e98
to
e6c298b
Compare
ishangupta-ds
force-pushed
the
feat/security-policy
branch
from
2d1801e
to
3deb7fd
Compare
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
3 times, most recently
from
0e34b92
to
c61367f
Compare
examples/resources/security_policy/resource_cluster_baseline_security_policy.tf
Outdated
Show resolved
Hide resolved
examples/resources/security_policy/resource_cluster_custom_security_policy.tf
Outdated
Show resolved
Hide resolved
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
from
c61367f
to
f832cd1
Compare
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
from
f832cd1
to
30dff58
Compare
Done @shreyassreenivas |
|
PTAL again, @shreyassreenivas , @Vasundharashukla and @shobha2626 |
Vasundharashukla
approved these changes
Aug 9, 2022
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
from
30dff58
to
0c5d9e9
Compare
Signed-off-by: Ishan Gupta <gishan@vmware.com>
Signed-off-by: Ishan Gupta <gishan@vmware.com>
Signed-off-by: Ishan Gupta <gishan@vmware.com>
Signed-off-by: Ishan Gupta <gishan@vmware.com>
Signed-off-by: Ishan Gupta <gishan@vmware.com>
Signed-off-by: Ishan Gupta <gishan@vmware.com>
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
4 times, most recently
from
3f4567e
to
2565db1
Compare
| allow_privilege_escalation = true | ||
| allow_host_namespace_sharing = true | ||
| allow_host_network = true | ||
| read_only_root_file_system = true |
There was a problem hiding this comment.
super nit : check the indentation of =
There was a problem hiding this comment.
Done @shreyassreenivas
|
If all the edge cases are tested and validated, feel free to merge the feature branch into master. |
Signed-off-by: Ishan Gupta <gishan@vmware.com>
Signed-off-by: Ishan Gupta <gishan@vmware.com>
ishangupta-ds
force-pushed
the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
from
2565db1
to
a14191f
Compare
yes. Merging this to the feature branch. After this, I will add the acceptance test. Also will add the |
|
ishangupta-ds
deleted the
gishan/security-policy-schema-and-resource-with-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ishan Gupta gishan@vmware.com
What this PR does / why we need it: This PR adds security policy schema and resource with unit tests.
Additional information: Tested for all the scenarios.