Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcd_network_routed_v2 does not have an attribute for Route Advertisement #1105

Closed
selmalatawey opened this issue Aug 9, 2023 · 11 comments 路 Fixed by #1203
Closed

vcd_network_routed_v2 does not have an attribute for Route Advertisement #1105

selmalatawey opened this issue Aug 9, 2023 · 11 comments 路 Fixed by #1203
Assignees

Comments

@selmalatawey
Copy link

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

CD 10.4+ allows the tenant to create a routed network with Route Advertisement enabled to allow the T1 gateway to advertise it to the north T0 gateway/provider gateway.
vcd_network_routed_v2 resource does not has have an argument for that.

Add an argument (Boolean) in vcd_network_routed_v2 resource which allows the tenant to automate enabling/disabling Route Advertisement for that specific routed network.

vcd_network_routed_v2
New argument:
route_advertised - Optional (VCD 10.4+) / Boolean if set to true, the network will be marked for advertisement by Org Edge to the north Provider GW and to the physical network. Default is false.

References

image

@Didainius Didainius self-assigned this Aug 9, 2023
@nnikodimov
Copy link

@Didainius, do you happen to have an update on when this is planned to be available? Enabling route advertisement for Public IP Space routed networks is quite a common use-case for VCD customers.

@lvirbalas
Copy link
Collaborator

lvirbalas commented Dec 20, 2023

@nnikodimov, it's too early to answer that (yet).

@koznov
Copy link

koznov commented Jan 8, 2024

That's a needed feature to enable option to advertise networks.

@eddie4
Copy link

eddie4 commented Jan 23, 2024

Any update on this?

@Didainius
Copy link
Collaborator

Hello,
This functionality is implemented in #1203. Would anyone want to give it a try?

@selmalatawey
Copy link
Author

@Didainius how can I pull that beta version including the fix?

@Didainius
Copy link
Collaborator

@selmalatawey , this would have to be done by manually building it from pull request branch manually (https://github.com/vmware/terraform-provider-vcd?tab=readme-ov-file#using-the-provider) . Alternatively, I could build it for you and share the binary in a cloud storage. To do that I would need to know the OS that you're going to run it in.

@oliverwiegers
Copy link

@Didainius I tested it. It works :) Amazing work. Thank you

@bogi0704
Copy link
Contributor

bogi0704 commented Feb 8, 2024

@Didainius The "Route Advertisement" settings have changed in the new version of VCD (v10.5.1). Now "Advertisement Strict", "Advertisement Flexible" and "All Networks Advertised" are offered. I would require these new settings to be set via terraform for our use-case.

@Didainius
Copy link
Collaborator

@Didainius The "Route Advertisement" settings have changed in the new version of VCD (v10.5.1). Now "Advertisement Strict", "Advertisement Flexible" and "All Networks Advertised" are offered. I would require these new settings to be set via terraform for our use-case.

@bogi0704 , just in time :) I will make a separate adjustment to add these, as this one is finalised now and is easier for team reviews.

@oliverwiegers
Copy link

Thanks for the patch :)

Is there an ETA for the next release that will contain this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants