Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Provider Gateway topology intentions on VCD 10.5.1 (NAT, FW, route advertisement) #1239

Merged
merged 14 commits into from
Jun 19, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Mar 26, 2024

This PR adds Topology intention configuration for Firewall, Nat and Route advertisement.

Ref: #1105 (comment)
Closes #1238
Closes #1208

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Add support Provider Gateway configuration for NAT and Firewall Rule intentions on VCD 10.5.1 Add support Provider Gateway topology intentions on VCD 10.5.1 (nat, fw, route advertisement) Mar 27, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review April 10, 2024 10:16
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@lvirbalas lvirbalas changed the title Add support Provider Gateway topology intentions on VCD 10.5.1 (nat, fw, route advertisement) Add support Provider Gateway topology intentions on VCD 10.5.1 (NAT, FW, route advertisement) Apr 12, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
go.mod Outdated Show resolved Hide resolved
vcd/resource_vcd_external_network_v2.go Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doubt

vcd/resource_vcd_external_network_v2.go Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 134e529 into vmware:main Jun 19, 2024
3 checks passed
@Didainius Didainius deleted the natfwintention branch June 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants