vcd/resource_vcd_vapp_network.go: Check for RESOLVED status for powering off vApp

[NilsBusche]

Fixes problem described in #1091
Closes #1091

[vmwclabot]

@NilsBusche, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 5c7dca3 must be signed by nils.busche@bertelsmann.de

[vmwclabot]

@NilsBusche, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 5c7dca3 must be signed by nils.busche@bertelsmann.de

[Didainius]

@NilsBusche ,
Thanks for the PR!. I'd like to clarify when do you get it to RESOLVED state?
I will have to reinforce it with a test so want to find out how to replicate the problem

[NilsBusche]

@Didainius vApp gets into RESOLVED, if you create it without any VMs in it or if you have a stopped vApp and remove all VMs from it.

[Didainius]

Thanks!

I have created a test that fails without your patch. The stupid part is that I can't make a PR to your repository as in the end it will probably ruin CLAbot (it doesn't like PRs that have multiple contributors).
Therefore I have put the patch to a gist - https://gist.github.com/Didainius/59b072055eb30949eed84dfe6c6a8621

Could you do a git apply patch.git after downloading that file. After it is here, we should be able to run a broader test suite to verify that nothing got broken along the way.

[NilsBusche]

I've added the patch

[Didainius]

Thanks. I am good with it. I ran tests with vm vapp network tags on 10.3.3 (which wouldn't be impacted anyway) and 10.4.2.

[dataclouder]

Thanks for your contribution!

[lvirbalas]

Thank you for contributing!

[Didainius]

Thank you @NilsBusche , this is merged and set for 3.11