Use minimal check with TestAccVcdSubscribedCatalog #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
requested review from
lvirbalas,
Didainius,
adambarreiro and
adezxc
as code owners
adambarreiro
approved these changes
Aug 1, 2023
lvirbalas
approved these changes
Aug 1, 2023
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Didainius
approved these changes
Aug 7, 2023
adezxc
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the network is busy,
TestAccVcdSubscribedCatalogmay lag more than usual, and some checks fail, because not all the catalog items have been downloaded in time. To minimize test failures, the checks on non-automatic downloads only test if one of the items was downloaded, rather than all.