Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edgegateway retrieval from VDC group #1129

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Fix edgegateway retrieval from VDC group #1129

merged 8 commits into from
Oct 16, 2023

Conversation

dataclouder
Copy link
Collaborator

@dataclouder dataclouder commented Oct 9, 2023 •
edited

Address Issue #1127

Fix incorrect behavior of vcd_resource_list, which can retrieve edge gateways belonging to a VDC, but not belonging to a VDC group.

@dataclouder
Fix retrieval of vcd_nsxt_edgegateway
72fc53a 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder
Add more tests for vcd_nsxt_edgegateway lists
cb63d14 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder
Add changelog item
eb9a004 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder changed the title Fix edgegateway vdc group retrieval Fix edgegateway retrieval from VDC group Oct 9, 2023
@dataclouder dataclouder marked this pull request as ready for review October 9, 2023 09:21
@dataclouder
Simplify VDC name retrieval
df1a9ca 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
lvirbalas
lvirbalas approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small ask in-line, and looks great!

.changes/v3.11.0/1129-bug-fixes.md Outdated Show resolved Hide resolved
@dataclouder
Update changelog entry
72c5c4f 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder self-assigned this Oct 9, 2023
adambarreiro
adambarreiro approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vcd/datasource_vcd_resource_list.go Outdated Show resolved Hide resolved
@dataclouder
Fix error message
c40c453 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder
Add custom gosec version for security check
3f90d9c 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder
Fix gosec.sh
f521f21 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder merged commit 9e049da into vmware:main Oct 16, 2023
2 checks passed
@dataclouder dataclouder mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@adezxc adezxc adezxc approved these changes

Assignees

@dataclouder dataclouder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dataclouder @adambarreiro @lvirbalas @Didainius @adezxc