Add support to metadata that is automatically added by VCD #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
requested review from
lvirbalas,
Didainius,
dataclouder and
adezxc
as code owners
4 tasks
lvirbalas
reviewed
Nov 3, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
approved these changes
Nov 3, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
dataclouder
reviewed
Nov 6, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
1 task
lvirbalas
approved these changes
Nov 8, 2023
dataclouder
approved these changes
Nov 8, 2023
adezxc
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the most recent versions of VCD, standalone VMs that are created from a vApp Template come with three metadata entries that are created automatically by VCD:
vm.origin.id,vm.origin.nameandvm.origin.type.This conflicts with the way metadata works in this Terraform provider, as any plan will ask to remove these "foreign" entries if one adds metadata to their VMs in their HCL configuration.
Solution
To avoid a bad experience when dealing with this casuistic, this metadata is filtered out from
metadataandmetadata_entryblocks and moved to a separated block only available invcd_vapp_vmandvcd_vm. This block is completely Computed and available for reading.Tests
Tests fail in the newest VCD versions as the expected metadata is n-3. After this feature, as metadata is filtered out, we get these n-3 entries and the removed 3 are in a separated block, which gets its own set of assertions.
vmacceptance tests pass 10.5.0vmtag upgrade tests pass 10.5.0vmacceptance tests pass on latest versionvmtag upgrade tests pass on latest version