Add support for vGPU policies #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quests return asterisks for the pre shared key Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
adezxc
requested review from
lvirbalas,
Didainius,
adambarreiro and
dataclouder
as code owners
|
Reminder: create changelog entry when we consider the feature complete |
Didainius
reviewed
Nov 27, 2023
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
adambarreiro
requested changes
Nov 30, 2023
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
dataclouder
reviewed
Dec 1, 2023
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
adambarreiro
approved these changes
Dec 1, 2023
dataclouder
approved these changes
Dec 1, 2023
Didainius
reviewed
Dec 1, 2023
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Didainius
reviewed
Dec 4, 2023
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
lvirbalas
reviewed
Dec 4, 2023
Didainius
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
I am good. There is one caveat that is not related to this PR and SDK needs fixing. Doing it in vmware/go-vcloud-director#636
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new things:
New resource and datasource:
vcd_vm_vgpu_policyNew datasource:
vcd_vgpu_profileNew field in
vcd_org_vdc:vm_vgpu_policy_idsNew field in
vcd_resource_pooldatasource:cluster_morefThere is a hack and a questionable decision regarding the field
vcd_vm_vgpu_policy.provider_vdc_scope.cluster_names: I'm not sure if there can be more than one cluster on which the provider VDC resides, so I have settled with a solution for ease of use: if a user doesn't specify any clusters, the provider tries to do it automatically by fetching the resource pool on which the PVDC is running.