Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overriding VM template disks in fast provisioned VDCs #1206

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Feb 8, 2024

override_template_disk configuration in vcd_vapp_vm and vcd_vm allows users to change template disk size. The current limitation is that it can only be done in non fast provisioned VDCs.

This PR adds consolidate_disks_on_create option to vcd_vapp_vm and vcd_vm that can perform disk consolidation before override_template_disk configuration is applied. The effect is that a user will be able to change template disk size when creating VMs in fast provisioned VDCs.

Note. The user performing this operation will need to have vApp: VM Migrate, Force Undeploy, Relocate, Consolidate right.

Closes #1000

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Add support for VM disk consolidation Add support for overriding VM template disks in fast provisioned VDCs Feb 8, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a great feature!

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, vm tests passed on 10.5.1

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 47eb6f0 into vmware:main Feb 22, 2024
3 checks passed
@Didainius Didainius deleted the vm-with-resizing branch February 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider doesn't customize disk template at request time but after VM creation
4 participants