Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #1218

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Fix tests #1218

merged 7 commits into from
Mar 12, 2024

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Mar 8, 2024

Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this Mar 8, 2024
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review March 12, 2024 11:09
Copy link
Collaborator

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Two small changes required.

vcd/datasource_vcd_cse_kubernetes_cluster_test.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_cse_kubernetes_cluster_test.go Outdated Show resolved Hide resolved
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit db1ea6a into vmware:main Mar 12, 2024
2 checks passed
@adambarreiro adambarreiro deleted the fix-datasource-tests branch March 12, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants