Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Lock source vApp when VM Copy is used, retry catalog item ID read #1219

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Mar 12, 2024

This PR contains these fixes:

  • Failure to retrieve catalog item ID. The fix is a retry as the vApp template sometimes lags to present it.
vcd_catalog_vapp_template.test_vapp_template1: Creation complete after 47s [id=urn:vcloud:vapptemplate:608d09db-48c6-4ce7-bfeb-331c59bfbfa0]
╷
│ Warning: Argument is deprecated
│
│   with data.vcd_catalog_media.test_media_by_catalog_name,
│   on config.tf line 136, in data "vcd_catalog_media" "test_media_by_catalog_name":
│  136:   catalog  = data.vcd_catalog.catalog_org1_from_org2.name
│
│ use catalog_id instead, especially if using a shared catalog
╵
╷
│ Error: error retrieving Catalog Item ID for vApp template: error finding Catalog Item link in vApp template urn:vcloud:vapptemplate:608d09db-48c6-4ce7-bfeb-331c59bfbfa0
  • Failure of vcd.TestAccVcdVAppVm_4types_PowerState-step2.tf binary test. Solution: Source vApp must be locked when creating copies of a VM (using copy_from_vm_id in vcd_vapp_vm and vcd_vm)
│ Warning: Argument is deprecated
│
│   with data.vcd_catalog_media.test_media_nsxt,
│   on config.tf line 50, in data "vcd_catalog_media" "test_media_nsxt":
│   50:   catalog = data.vcd_catalog.cat-v51-nsxt-backed.name
│
│ use catalog_id instead, especially if using a shared catalog
╵
╷
│ Error: error creating VM copy: [VM creation] error getting VM TestAccVcdVAppVm_4types_PowerState-empty-vapp-vm-copy : error instantiating a new VM:
API Error: 400: [ b85ad5e7-73a3-4c06-b649-bd86763a1968 ] The entity Ref: com.vmware.vcloud.entity.vm:3bd97119-d3fe-460c-a6c2-089c11f2c0e1 is busy comp
leting an operation VDC_RECOMPOSE_VAPP. VDC_RECOMPOSE_VAPP(com.vmware.vcloud.entity.task:71f41622-80bc-41ed-935d-8bc96d30c983)
│
│   with vcd_vapp_vm.empty-vm-copy,
│   on config.tf line 170, in resource "vcd_vapp_vm" "empty-vm-copy":
│  170: resource "vcd_vapp_vm" "empty-vm-copy" {

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Fix: Lock parent vApp of source VM when VM Copy is used Fixes: Lock source vApp when VM Copy is used, retry catalog item ID read Mar 12, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review March 12, 2024 12:56
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius removed the request for review from lvirbalas March 12, 2024 13:17
@Didainius Didainius merged commit 20f828f into vmware:main Mar 12, 2024
2 checks passed
@Didainius Didainius deleted the troubleshoot-test branch March 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants