Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site and Org associations #1260

Merged
merged 67 commits into from
Jun 24, 2024
Merged

Conversation

dataclouder
Copy link
Collaborator

@dataclouder dataclouder commented Apr 30, 2024

Add resources and data sources to handle site and org associations:

Data sources:

  • vcd_multisite_site to read site information
  • vcd_multisite_site_data to get association data from current site
  • vcd_multisite_site_association to show information about an existing site association
  • vcd_multisite_org_data to get association data from current org
  • vcd_multisite_org_association to show information about an existing org association
  • Improve vcd_resource_list to show lists of vcd_multisite_site_association and vcd_multisite_org_association

Resources:

  • vcd_multisite_site_association to create and remove site associations
  • vcd_multisite_org_association to create and remove org associations

Miscellaneous

  • Add import procedures
  • Write comprehensive test
  • Check data-source-not-found test
  • Check org-user test
  • Check binary test
  • Write documentation for each resource/data source
  • write a guide for site and org association operations
  • Write examples for some association workflows

To test, read the note in TestVcdMultisiteSiteAssociation, containing the environment variables we need to set to start the test.
(Tested with 10.4.2, 10.5.1, 10.6.0)

Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder dataclouder self-assigned this Apr 30, 2024
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Add update stage with relevant checks

Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. Looks awesome.

website/docs/guides/site_org_association.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/site_org_association.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/site_org_association.html.markdown Outdated Show resolved Hide resolved
website/docs/r/multisite_org_association.html.markdown Outdated Show resolved Hide resolved
website/docs/r/multisite_org_association.html.markdown Outdated Show resolved Hide resolved
website/docs/r/multisite_site_association.html.markdown Outdated Show resolved Hide resolved
website/docs/r/multisite_site_association.html.markdown Outdated Show resolved Hide resolved
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great!

Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few queries that I leave before testing

vcd/datasource_vcd_multisite_site.go Show resolved Hide resolved
vcd/resource_vcd_multisite_org_association.go Show resolved Hide resolved
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built configs from scratch by only checking the docs and both site and org associations went well. Also ran tests

Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multisite tests passed in 10.5.1.1

website/vcd.erb Outdated Show resolved Hide resolved
website/vcd.erb Show resolved Hide resolved
vcd/resource_vcd_multisite_org_association.go Show resolved Hide resolved
vcd/datasource_vcd_multisite_org_association.go Outdated Show resolved Hide resolved
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder dataclouder merged commit 8334ce4 into vmware:main Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants