Add NSX-T VDC Group support for vcd_network_routed_v2, vcd_network_isolated_v2 and vcd_nsxt_network_imported #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
changed the title
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
from
d5076fd
to
d7e48b0
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
from
d7e48b0
to
10650b0
Compare
Didainius
changed the title
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
2 times, most recently
from
28eac9a
to
c80ad82
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
from
c80ad82
to
de245dd
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
9 times, most recently
from
27c37c1
to
b2beb81
Compare
Didainius
changed the title
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
from
b2beb81
to
0798941
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
from
0798941
to
f801e89
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
Mar 23, 2022
lvirbalas
approved these changes
Mar 23, 2022
adambarreiro
approved these changes
Mar 23, 2022
vbauzys
approved these changes
Mar 23, 2022
vbauzys
reviewed
Mar 23, 2022
No doubt about that. I dont like it myself. |
mikeletux
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
LA(Awesome)TM!
My manual testing was especially focused on backwards compatibility, moving from vdc to owner_id and everything worked as expected.
Also moved back and forth from single VDC to VDC groups and also everything worked as a charm!
It's true that in the future smaller PRs would be great 😄
Thanks for this awesome implementation!
vbauzys
reviewed
Mar 23, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds VDC Group support for:
vcd_network_routed_v2(deprecatesvdcfield and instead inherits parent VDC / VDC Group from NSX-T Edge Gateway)vcd_network_isolated_v2(deprecatesvdcfield in favor ofowner_idwhich can be VDC and VDC Group)vcd_nsxt_network_imported(deprecatesvdcfield in favor ofowner_idwhich can be VDC and VDC Group)There is a major difference how these resources support it. Routed networks follow the location of parent Edge Gateway ID - move together to VDC Group and back.
It is worth reading a new Guides doc page at first (https://github.com/vmware/terraform-provider-vcd/blob/b2beb8152cee15627e3220003498244fd5379223/website/docs/guides/vdc_groups.html.markdown) which outlines details done so far.
Locking mechanism has changed:
org:vdc:nameformat.lockIfOwnerIsVdcGroup(d)andunLockIfOwnerIsVdcGroupare introduced to only lock onownerRefif it is VDC Group (this is required for imported and isolated networks)vcd_network_routed_v2because if it is a member of simple VDC - lock must be acquired on Edge Gateway, but if it is a member of VDC Group - a lock must be acquired on VDC Group.Note. The goal of this PR is to preserve backwards compatibility and not break anything for existing users.
vdcfields are deprecated in favor ofowner_id(for isolated network) andedge_gateway_id(for routed network), but they still work.Additionally:
Ran acceptance, org user acceptance, binary and upgrade tests with tags
network nsxt vdcGroup edgegateway