Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata support for VDC networks #804

Merged
merged 21 commits into from
Mar 28, 2022
Merged

Add metadata support for VDC networks #804

merged 21 commits into from
Mar 28, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Mar 15, 2022 •
edited

This PR aims to enhance the VCD network resources and datasources to support metadata creation, read and update.

⚠️ Depends on: vmware/go-vcloud-director#442
Related issue: #372

Changes:

  • Added metadata field in direct, routed and isolated network datasources/resources.
  • Removed redundant code.
  • Updated to the most recent Terraform SDK method signatures, with *Context methods and diag.Diagnostics.
  • Updated tests accordingly to check metadata behaviour is correct.

Note: v2 networks will come in another PR as I noticed too late that they would require an OpenAPI implementation in go-vcloud-director.

@adambarreiro
Initial change
acc9baf 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this Mar 15, 2022
@adambarreiro
Add changelog
bf57c73 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
go mod
05ee93d 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
aa962ac 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Update deprecated signatures
a1ac9d1 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro mentioned this pull request Mar 17, 2022
Closed
@adambarreiro
#
1ec91ca 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Add metadata tests to network tests
8896970 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix test
f18a4cf 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix test partially, still fail
baea7be 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
09815ad 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
62296d9 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
5799d65 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
fmt
bdab049 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review March 22, 2022 09:34
@adambarreiro adambarreiro removed the request for review from dataclouder March 22, 2022 09:34
@vbauzys
Copy link
Contributor

vbauzys commented Mar 22, 2022

PR has conflicts :)

vbauzys
vbauzys suggested changes Mar 22, 2022
View reviewed changes
vcd/resource_vcd_network_isolated.go Outdated Show resolved Hide resolved
vcd/resource_vcd_network_test.go Outdated Show resolved Hide resolved
@adambarreiro
Apply suggestions
c9bf1b8 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix wrong spacing
1979ae2 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix wrong spacing
cf3fc6b 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Added network type to log
0e5ce96 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
8a24e5d 
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
lvirbalas approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean :)

@adambarreiro
Update Go SDK to alpha.8
ca3e8e5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
mikeletux
mikeletux approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@mikeletux mikeletux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved!

@adambarreiro
Merge from main
e622a83 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Merge branch 'main' of https://github.com/adambarreiro/terraform-prov…
3021d99 
…ider-vcd into add-network-metadata

Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit dc40d85 into vmware:main Mar 28, 2022
@adambarreiro adambarreiro mentioned this pull request Apr 5, 2022
Merged
@adambarreiro adambarreiro deleted the add-network-metadata branch October 3, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeletux mikeletux mikeletux approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@vbauzys vbauzys vbauzys approved these changes

Assignees

@adambarreiro adambarreiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adambarreiro @vbauzys @mikeletux @lvirbalas @Didainius