Add NSX-T VDC Group support for vcd_nsxt_ip_set

[vbauzys]

Dep: vmware/go-vcloud-director#451

This PR adds VDC Group support for:

• vcd_nsxt_ip_set (deprecates vdc field and instead inherits parent VDC / VDC Group from NSX-T Edge Gateway)

There is a major difference in how these resources support it. IP Set follows the location of parent Edge Gateway ID - move together to VDC Group and back.

Note. The goal of this PR is to preserve backward compatibility and not break anything for existing users. vdc fields are deprecated in favor of edge_gateway_id.

Additionally:

Ran tests on 10.3.1 and 10.2.2 and upgrade tests

[Didainius]

If you can add this item to the list in VDC Group guides page https://github.com/vmware/terraform-provider-vcd/blob/main/website/docs/guides/vdc_groups.html.markdown?plain=1#L65-L68

[vbauzys]

If you can add this item to the list in VDC Group guides page https://github.com/vmware/terraform-provider-vcd/blob/main/website/docs/guides/vdc_groups.html.markdown?plain=1#L65-L68

added

[adambarreiro]

LGTM!

[Didainius]

Manual testing for migrations of 3.5.1 -> 3.6.0 with same configuration and then adjusting to new format looked to be working without recreation.

Would be nice to the test @lvirbalas mentioned just to have it covered which can take inspiration from TestAccVcdNetworkRoutedV2InheritedVdc how to patch vdc field for testing.

[vbauzys]

Manual testing for migrations of 3.5.1 -> 3.6.0 with same configuration and then adjusting to new format looked to be working without recreation.

Would be nice to the test @lvirbalas mentioned just to have it covered which can take inspiration from TestAccVcdNetworkRoutedV2InheritedVdc how to patch vdc field for testing.

IP Sets have similar unit test TestAccVcdNsxtIpSetInheritedVdc

[mikeletux]

I did some thorough manual testing and everything worked as expected.
Thanks!