-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata support for storage profile datasource #811
Add metadata support for storage profile datasource #811
Conversation
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
could you check, maybe in config-gen we could use vpshere provider to add metadata in storage profile :) |
There seems to be a resource for storage policies: https://registry.terraform.io/providers/hashicorp/vsphere/latest/docs/resources/vm_storage_policy |
Yes, you are right, even we could import resource we still add metadata on vpshere level, not VCD |
Signed-off-by: abarreiro <abarreiro@vmware.com>
Created by #372
:warn: Depends on vmware/go-vcloud-director#454
This PR adds metadata support (read) for the storage profile datasource. This was tested manually, as there is no
vcd_storage_profile
resource to manipulate metadata. The manual test is as follows: