Add NSX-T VDC Group support for vcd_nsxt_security_group #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oups Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
vbauzys
requested review from
lvirbalas,
dataclouder,
Didainius,
adambarreiro and
mikeletux
as code owners
Didainius
reviewed
Apr 4, 2022
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
lvirbalas
reviewed
Apr 5, 2022
mikeletux
reviewed
Apr 5, 2022
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Didainius
approved these changes
Apr 6, 2022
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dep: vmware/go-vcloud-director#456
This PR adds VDC Group support for:
vdcfield and instead inherits parent VDC / VDC Group from NSX-T Edge Gateway)There is a major difference in how these resources support it. Security group follows the location of parent Edge Gateway ID - move together to VDC Group and back.
Note. The goal of this PR is to preserve backward compatibility and not break anything for existing users.
vdcfields are deprecated in favor ofedge_gateway_id.Additionally:
Ran tests on 10.3.1 and 10.2.2 and upgrade tests