Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data source and resource fixes + NVMe binary test skip for VCD <10.2.2 #838

Merged
merged 3 commits into from
May 6, 2022
Merged

Data source and resource fixes + NVMe binary test skip for VCD <10.2.2 #838

merged 3 commits into from
May 6, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Apr 28, 2022 •
edited

This PR adds 3 fixes as mentioned in CHANGELOG:

  • Skip binary and upgrade tests for NVMe in VCD < 10.2.2 . NVMe is not supported in 10.2.0 and binary tests fail because of that. I have confirmed this running make test-binary-prepare on 10.2.0 and 10.3.3
  • Network lookup could return incorrect ID for vcd_vapp_network and vcd_vapp_org_network. Not trivial to test this one - but it can impact environments with more networks
  • Set missing org and vdc fields during import of vcd_independent_disk. This fails in a combination of parameters which are not hit by our tests

@Didainius
Skip NVMe related binary tests in VCD < 10.2.2
0a84a41 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add fixes for datasources
d99eeb6 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add changelog
e34c5d2 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review April 29, 2022 05:42
@lvirbalas lvirbalas removed the request for review from dataclouder April 29, 2022 06:22
@Didainius Didainius merged commit c27161d into vmware:main May 6, 2022
@Didainius Didainius deleted the fixes branch May 6, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@mikeletux mikeletux mikeletux approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@dataclouder dataclouder dataclouder approved these changes

@vbauzys vbauzys vbauzys approved these changes

Assignees
No one assigned
Labels
test-failed:acc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Didainius @adambarreiro @mikeletux @lvirbalas @dataclouder @vbauzys @terraform-provider-vcd-bot