Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CatalogItem metadata support for vcd_catalog_item #851

Merged
merged 10 commits into from
May 19, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented May 12, 2022

Description

This PR adds the capability of including metadata in the vcd_catalog_item resource that belongs to the CatalogItem itself, as right now the metadata attribute belongs to the associated vApp template. The new attribute for this is called catalog_item_metadata.

The data source has been also updated to fetch the CatalogItem metadata into that attribute.

Documentation and log messages have been updated accordingly.

The changes somehow relate to the issue #502

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this May 12, 2022
@adambarreiro
Copy link
Collaborator Author

Tested manually and works.

@adambarreiro adambarreiro marked this pull request as ready for review May 12, 2022 13:33
@adambarreiro adambarreiro changed the title Add metadata support for Catalog Item Add CatalogItem metadata support for vcd_catalog_item May 12, 2022
.changes/v3.7.0/851-features.md Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_item.go Show resolved Hide resolved
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests, but approving in advance. Don't hesitate to resolve my comments when ready to merge this time.

.changes/v3.7.0/851-features.md Outdated Show resolved Hide resolved
website/docs/r/catalog_item.html.markdown Outdated Show resolved Hide resolved
website/docs/d/catalog_item.html.markdown Show resolved Hide resolved
@vmwclabot
Copy link
Member

@adambarreiro, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@adambarreiro, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro removed the request for review from dataclouder May 17, 2022 13:11
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit fb53fcc into vmware:main May 19, 2022
@adambarreiro adambarreiro deleted the add-catalog-item-metadata branch May 19, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants