Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSE 3.1.x guide and example to install it with the VCD Provider #856

Merged
merged 52 commits into from
Jun 28, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented May 18, 2022

This PR doesn't have an issue associated.

Description

This PR adds a new guide to the Guides section of the documentation. The new guide explains how to set up VCD in order to start using the Container Service Extension to provision Kubernetes clusters.

As an extra, it also provides a few Terraform examples in the examples section of this repository.

Finally, it fixes a broken link I found during the writing of the guide.

Testing

Ideally, this PR should be tested in an empty VCD, or in a VCD with a minimal setup, and without knowledge of CSE. This way one can propose improvements on the guide or can detect pitfalls in the examples provided. I could provision a "CSE-ready VCD" following the steps, but I may be a bit biased as I have all the process already memorised and could have took something for granted.

Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ider-vcd into add-cse-docs

Signed-off-by: abarreiro <abarreiro@vmware.com>
…ider-vcd into add-cse-docs

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this May 31, 2022
@adambarreiro adambarreiro marked this pull request as ready for review May 31, 2022 14:40
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial asks, looks neat overall!

examples/container-service-extension/3.7-cse-step1.tf Outdated Show resolved Hide resolved
examples/container-service-extension/3.7-cse-step1.tf Outdated Show resolved Hide resolved
examples/container-service-extension/3.7-cse-step3.tf Outdated Show resolved Hide resolved
…ider-vcd into add-cse-docs

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After re-reading, few more asks. I hope they are specific enough to understand right.

Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just first insights :)

examples/container-service-extension/3.7-cse-step1.tf Outdated Show resolved Hide resolved
examples/container-service-extension/3.7-cse-step1.tf Outdated Show resolved Hide resolved
examples/container-service-extension/3.7-cse-step1.tf Outdated Show resolved Hide resolved
examples/container-service-extension/3.7-cse-step1.tf Outdated Show resolved Hide resolved
examples/container-service-extension/3.7-cse-step1.tf Outdated Show resolved Hide resolved
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ript

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Copy link
Collaborator Author

adambarreiro commented Jun 28, 2022

Will do a last run of testing the guide and ready to merge.

  • Example test complete and working

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first stage of CSE support!

Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro changed the title Add CSE guide to install it with the VCD Provider Add CSE 3.1.x guide and example to install it with the VCD Provider Jun 28, 2022
@adambarreiro adambarreiro merged commit 455e658 into vmware:main Jun 28, 2022
@adambarreiro adambarreiro deleted the add-cse-docs branch June 28, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants