-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vcd_nsxt_dynamic_security_group resource and data source #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
force-pushed
the
dynamic_groups-pr
branch
from
June 30, 2022 12:51
22116c3
to
6e0e466
Compare
Didainius
force-pushed
the
dynamic_groups-pr
branch
from
June 30, 2022 12:58
6e0e466
to
0b537aa
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
vbauzys and
adambarreiro
as code owners
July 1, 2022 09:19
lvirbalas
requested changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts and suggestions.
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
Jul 15, 2022
adambarreiro
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just minor things
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #459, #787
Starting with VCD 10.3 there is a concept called Dynamic Security Groups which allows users to define dynamic rules (based on names and tags) for firewall group membership.
This PR introduces
vcd_nsxt_dynamic_security_group
resource and data source.Note. Dynamic Security Groups require VCD 10.3+ and an NSX-T VDC Group. Meeting these prerequisites allow to create these groups and consume them in both Edge Gateway firewalls (provided Edge Gateway is a member of VDC Group) and Distributed firewalls.
Note2. As opposed to IP Sets and Static Security Groups, Dynamic security groups can only be scoped to VDC Groups and a self-explanatory error is returned if they are scoped to Edge Gateway in a VDC only:
This is the reason a field is called
vdc_group_id
instead ofowner_id
where we use it to accept different objects.More about Dynamic Security Groups in VCD official docs and VMware Blog post: