Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to use NSX-T based VDC #886

Merged
merged 59 commits into from
Jul 29, 2022
Merged

Convert tests to use NSX-T based VDC #886

merged 59 commits into from
Jul 29, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jul 28, 2022 •
edited

This PR replaces #869 and continues making NSX-T VDC the main VDC for testing (instead of NSX-V one).

It is merged with the latest main branch.

WIP log for VCD working tests:

  • All TestAccDataSourceNotFound pass
  • Fixed and made TestAccVcdMediaInsertBasic and TestAccVcdMediaLockTest pass
  • Fixed TestAccVcdSecurityTag
  • Fixed TestAccVcdNsxtStandaloneEmptyVm
  • Fixed TestAccVcdNsxtVAppRawAllNsxtNetworks
  • Fixed TestAccVcdCatalogSharedAccess
  • Fixed TestAccVcdOpenApiDhcpNsxtRouted for VCD < 10.3.1
  • Fixed TestAccVcdCatalogItemBasic for VCD 10.2.0
  • Skipping TestAccVcdOrgGroup on VCD 10.2.0 because NSX-T Direct Network is not supported

@vbauzys
converted vdc crud test to use NSX-T
0929aa4 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change search engine tests
0ce0e02 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change datasource not found tests
289260a 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change vcd_external_network_v2 test
a912723 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change independent disk tests
a637d63 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdNsxtAppPortProfileMultiOrg test
daa69b9 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdVdcDatasource test
0bb3bbb 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdDatasourceResourceList test
fdb6909 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdStorageProfileDS test
6903ff7 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
add comment
a73db5d 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdVappOrgNetworkDS test
55b32ad 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdVappDS test
8232d9e 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdVappVmDS test
615d1a1 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change catalog tests
30b710b 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
improve tests
81623ce 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdMediaInsertBasic test
38dd6b1 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdNetworkIsolatedV2Nsxt tests
67ec5de 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdNetworkRoutedV2Nsxt tests
58595f2 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
fix TestAccVcdNetworkIsolate tests
06f722f 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
fix TestAccVcdNetworkRouted and Direct tests
f319f16 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
fix TestAccVcdNsxtAppPortProfileConfigurationMigration and TestAccVcd…
fde80fa 
…NsxtAppPortProfileTenantContextVdcGroup tests

Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
fix TestAccVcdDistributedFirewall tests
3fc755b 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
fix TestAccVcdNsxtEdgeGateway tests
22616e1 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdNsxtIpSet tests
5ea9da8 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdNetworkImportedNsxtMigration tests
c38a8ff 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
change TestAccVcdNsxtSecurityGroupOwnerVdcGroup tests
54b11b6 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
add note to TestAccVcdNsxtStandaloneVmTemplate test
0d3687e 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
fix TestAccVcdNsxvDhcpRelay test
d3ccd0d 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
fix TestAccVcdStandaloneVmTemplate test
e0ecc57 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@vbauzys
revert test as it was Nxsv based
f102e29 
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
@Didainius Didainius mentioned this pull request Jul 28, 2022
Closed
@Didainius Didainius changed the title Converted tests to use NSX-T based VDC Convert tests to use NSX-T based VDC Jul 28, 2022
@Didainius
Merge branch 'main' into cds-tests
060d0d6 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius self-assigned this Jul 28, 2022
@Didainius
Fix TestAccVcdSecurityTag
0b46e5f 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix TestAccVcdNsxtStandaloneEmptyVm
ee145e7 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix TestAccVcdNsxtVAppRawAllNsxtNetworks
9848d9a 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix TestAccVcdCatalogSharedAccess
15c8688 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix TestAccVcdOpenApiDhcpNsxtRouted
b82e791 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix TestAccVcdCatalogItemBasic for VCD 10.2.0
95c56a4 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Skip TestAccVcdOrgGroup on VCD 10.2.0 because NSX-T Direct Network is…
be39e46 
… not supported

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Merge branch 'main' into cds-tests
3605cbe 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Merge branch 'main' into cds-tests
d477606 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add note and sleep in test to wait for dynamic security group member …
47a7c64 
…update

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Adjust sleep to 10 seconds for dynamic security group membership popu…
967c4fc 
…lation

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review July 29, 2022 10:18
@Didainius
Add changelog
2cc73d6 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
lvirbalas approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and LGTM!

vcd/resource_vcd_nsxt_dynamic_security_group_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_dynamic_security_group_test.go Outdated Show resolved Hide resolved
.changes/v3.7.0/886-notes.md Outdated Show resolved Hide resolved
website/docs/r/nsxt_dynamic_security_group.html.markdown Outdated Show resolved Hide resolved
@Didainius
Address comments
7b31cfe 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adambarreiro
adambarreiro approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Didainius Didainius merged commit 9520a8d into vmware:main Jul 29, 2022
@Didainius Didainius deleted the cds-tests branch July 29, 2022 11:43
@Didainius Didainius mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@Didainius Didainius

Labels
test-failed:acc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Didainius @adambarreiro @lvirbalas @terraform-provider-vcd-bot @vbauzys