Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource vcd_catalog_access_control #915

Merged
merged 8 commits into from
Oct 18, 2022

Conversation

dataclouder
Copy link
Collaborator

@dataclouder dataclouder commented Sep 29, 2022

Resource vcd_catalog_access_control is modeled after vcd_vapp_access_control and vcd_org_vdc_access_control.
Given a catalog, this resource can add and modify access control settings, either general (share with everyone) or detailed (share with one or more orgs, groups, users).

Addresses issue #777

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder marked this pull request as ready for review September 30, 2022 04:01
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little minor things I saw in a first check.

vcd/resource_vcd_catalog_access_control.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_access_control.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_access_control_test.go Outdated Show resolved Hide resolved
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice!

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@carmine73
Copy link

carmine73 commented Feb 6, 2024

hi @dataclouder, I see there is no data source vcd_catalog_access_control, is there a way to add a org in a vcd_catalog_access_control?

@dataclouder
Copy link
Collaborator Author

is there a way to add a org in a vcd_catalog_access_control?

@carmine73 there is already an org in vcd_catalog_access_control.
If what you need is a data source, it is missing by choice. None of the vcd_*_access_control entities has a data source.
Should you need it, please open an issue, explaining the use case.

@carmine73
Copy link

ok, trying to explain my use case here #1209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants