Fix Issue #672 - update Org with invalid LDAP #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Org that has its LDAP settings changed outside Terraform (possibly without error checking and thus incomplete) would fail to update. This check will prevent invalid LDAP settings from being sent to VCD during the Org update. Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
requested review from
lvirbalas,
Didainius and
adambarreiro
as code owners
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Didainius
reviewed
Dec 7, 2022
Didainius
approved these changes
Dec 7, 2022
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
lvirbalas
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Org that has its LDAP settings changed outside Terraform (possibly without error checking and thus incomplete) would fail to update.
This check will prevent invalid LDAP settings from being sent to VCD during the Org update.