Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use changed LDAP structure field sequence #955

Merged
merged 4 commits into from
Dec 12, 2022

Conversation

dataclouder
Copy link
Collaborator

@dataclouder dataclouder commented Dec 9, 2022

Addresses Issue #672 (again!) with changed field sequence in LDAP configuration.

In addition to failing with invalid LDAP configuration, the update also fails when using group_back_link_identifier, which was not in the right position in go-vcloud-director types. This change picks the right field sequence.

Test for compatibility:

go test -tags functional -run 'TestAccVcdOrgLdap|TestAccVcdOrgGroup' -v -timeout 0

Test for this specific issue:

  1. apply the script from this issue comment: (change the LDAP server IP or hostname).
  2. remove terraform state file
  3. remove or comment out from the script the resource vcd_org_ldap.dummy
  4. run terraform import vcd_org.dummy dummy
  5. Change the org description and run terraform apply
  6. check in the UI that the LDAP configuration persists, and that you can import groups.

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder marked this pull request as ready for review December 9, 2022 18:44
@dataclouder dataclouder self-assigned this Dec 9, 2022
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants