Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalog_item_entitlement data source and resource #425

Merged
merged 3 commits into from Feb 22, 2022

Conversation

frodenas
Copy link
Member

Overrides #420. Fixes #345.

mars4life and others added 3 commits February 9, 2022 18:19
Signed-off-by: Amakou MBATA <mars4life@gmail.com>
Signed-off-by: Ferran Rodenas <rodenasf@vmware.com>
Signed-off-by: Ferran Rodenas <rodenasf@vmware.com>
Copy link
Contributor

@dondon3345678 dondon3345678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need any change on website pages? Like examples/catalog_item

@frodenas
Copy link
Member Author

Thanks Daniel. I already updated the examples/catalog_item/main.tf, and added new docs for the new data source and resource.

@mars4life
Copy link
Contributor

@frodenas Thanks for picking up the topic :)

Copy link
Contributor

@dondon3345678 dondon3345678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more examples. Approved.

@frodenas frodenas merged commit 3b5ae8a into main Feb 22, 2022
@frodenas frodenas deleted the catalog-item-entitlement branch February 22, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to add a specific catalog item to a new project and not the whole source
3 participants