Skip to content

Commit

Permalink
vdk-core: do not count memory properties toward the count (#3099)
Browse files Browse the repository at this point in the history
Property type "memory" comes with vdk-core. If another one like
fs-client proeprty comes it will call ambiguity order but that's
unecesary since memory is only useful for unit testing. Otherwise it's
not and we should defualt to the other one if only two are available.
  • Loading branch information
antoniivanov committed Feb 9, 2024
1 parent 62961c7 commit 7467786
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,14 @@ def __setup_properties_from_factory_method(self):
factory_method = self.__properties_builders[
list(self.__properties_builders.keys())[0]
]
elif (
len(self.__properties_builders) == 2
and "memory" in self.__properties_builders.keys()
):
properties_type = list(self.__properties_builders.keys())[0]
if properties_type == "memory":
properties_type = list(self.__properties_builders.keys())[1]
factory_method = self.__choose_from_default_type(properties_type)
else:
errors.report_and_throw(
errors.VdkConfigurationError(
Expand Down

0 comments on commit 7467786

Please sign in to comment.