Skip to content

Commit

Permalink
frontend: enable stable tagging (#2378)
Browse files Browse the repository at this point in the history
## Why?

#2332

This issue has been resolved, so we can re-enable stable tagging for the
frontend. The change lets us use our CI/CD pipeline to deliver updates
to the frontend and quickstart-vdk with sufficient release confidence.

## What?

Enable stable tagging for the frontend docker image. This lets us
deliver updates for the
frontend as part of quickstart-vdk.

Note: The stable tag is pulled each time quickstart-vdk is restarted and
the helm chart it uses re-deployed

## How was this tested?

The stable tagging job ran as part of the CI before, we just didn't have
sufficient testing around
the frontend image, so we disabled it. We use the same script for
tagging with latest, so
it should be fine.

## What kind of change is this?

Feature/non-breaking

Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
  • Loading branch information
DeltaMichael committed Jul 11, 2023
1 parent a3616bb commit 7cf915e
Showing 1 changed file with 17 additions and 18 deletions.
35 changes: 17 additions & 18 deletions projects/frontend/cicd/.gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,24 +127,23 @@ frontend_publish_ui_image:
changes: *frontend_data_pipelines_locations
extends: .frontend_publish_docker_image

# TODO: Enable this when https://github.com/vmware/versatile-data-kit/issues/2332 is resolved
# frontend_tag_ui_image_stable:
# stage: release
# before_script:
# - cd projects/frontend
# script:
# - apk --no-cache add bash git
# - export IMAGE_TAG="$(git rev-parse --short HEAD)"
# - docker login --username "${VDK_DOCKER_REGISTRY_USERNAME}" --password "${VDK_DOCKER_REGISTRY_PASSWORD}" "${VDK_DOCKER_REGISTRY_URL}"
# - bash -ex ../../projects/control-service/cicd/tag_image_dockerhub.sh vdk-operations-ui $IMAGE_TAG stable
# rules:
# - if: '$CI_PIPELINE_SOURCE == "schedule"'
# when: never
# - if: '$CI_COMMIT_BRANCH == "main"'
# changes: *frontend_shared_components_locations
# - if: '$CI_COMMIT_BRANCH == "main"'
# changes: *frontend_data_pipelines_locations
# extends: .frontend_publish_docker_image
frontend_tag_ui_image_stable:
stage: release_image
before_script:
- cd projects/frontend
script:
- apk --no-cache add bash git
- export IMAGE_TAG="$(git rev-parse --short HEAD)"
- docker login --username "${VDK_DOCKER_REGISTRY_USERNAME}" --password "${VDK_DOCKER_REGISTRY_PASSWORD}" "${VDK_DOCKER_REGISTRY_URL}"
- bash -ex ../../projects/control-service/cicd/tag_image_dockerhub.sh vdk-operations-ui $IMAGE_TAG stable
rules:
- if: '$CI_PIPELINE_SOURCE == "schedule"'
when: never
- if: '$CI_COMMIT_BRANCH == "main"'
changes: *frontend_shared_components_locations
- if: '$CI_COMMIT_BRANCH == "main"'
changes: *frontend_data_pipelines_locations
extends: .frontend_publish_docker_image

frontend_deploy_testing_data_pipelines:
stage: pre_release_test
Expand Down

0 comments on commit 7cf915e

Please sign in to comment.