vdk-kerberos-auth: fix unit test failing from bad logging config (#2923)

# Why? Test was failing # Why? change logging config # How was this tested? CICD --------- Co-authored-by: paulm2 <paulm2@vmware.com>
vmware · Nov 24, 2023 · 8be388d · 8be388d
1 parent 3b7c9ae
commit 8be388d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/projects/vdk-plugins/.plugin-common.yml b/projects/vdk-plugins/.plugin-common.yml
@@ -44,9 +44,9 @@
        - "projects/vdk-core/src/**/*"
 
 .build-plugin-dind:
-  image: docker:23.0.1
+  image: docker:23.0.6
   services:
-    - docker:23.0.1-dind
+    - docker:23.0.6-dind
   variables:
     DOCKER_HOST: tcp://localhost:2375
     DOCKER_DRIVER: overlay2

diff --git a/projects/vdk-plugins/vdk-kerberos-auth/.plugin-ci.yml b/projects/vdk-plugins/vdk-kerberos-auth/.plugin-ci.yml
@@ -11,6 +11,8 @@
     - export DEBIAN_FRONTEND=noninteractive
     - apt-get update
     - apt-get install -y krb5-user
+#   the line below needs to be removed when cryptolib 1.3.1 or 1.4.0 is released https://community.snowflake.com/s/article/Python-Connector-fails-to-connect-with-LibraryNotFoundError-Error-detecting-the-version-of-libcrypto
+    - pip install https://github.com/wbond/oscrypto/archive/d5f3437ed24257895ae1edd9e503cfb352e635a8.zip
     - !reference [.build-plugin, script]
   extends: .build-plugin-dind
 

diff --git a/projects/vdk-plugins/vdk-kerberos-auth/tests/test_kerberos.py b/projects/vdk-plugins/vdk-kerberos-auth/tests/test_kerberos.py
@@ -38,7 +38,10 @@ def setUp(self) -> None:
     def test_no_authentication(self):
         with mock.patch.dict(
             os.environ,
-            {"VDK_KRB_AUTH_FAIL_FAST": "true"},
+            {
+                "VDK_KRB_AUTH_FAIL_FAST": "true",
+                "VDK_LOG_EXECUTION_RESULT": "True",
+            },
         ):
             result: Result = self.__runner.invoke(
                 ["run", jobs_path_from_caller_directory("test-job")]
@@ -67,6 +70,7 @@ def test_kinit_authentication(self):
                 "VDK_KRB_AUTH": "kinit",
                 "VDK_KRB_AUTH_FAIL_FAST": "true",
                 "VDK_KRB5_CONF_FILENAME": krb5_conf_filename,
+                "VDK_LOG_EXECUTION_RESULT": "True",
             },
         ):
             result: Result = self.__runner.invoke(
@@ -211,6 +215,7 @@ def test_minikerberos_authentication(self):
                 "VDK_KEYTAB_REALM": "EXAMPLE.COM",
                 "VDK_KERBEROS_KDC_HOST": "localhost",
                 "VDK_KRB5_CONF_FILENAME": krb5_conf_filename,
+                "VDK_LOG_EXECUTION_RESULT": "True",
             },
         ):
             result: Result = self.__runner.invoke(