vdk-core: add new configuration log_level_module #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gageorgiev
requested changes
Sep 1, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/config/log_config.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/tests/vdk/internal/builtin_plugins/config/test_log_config.py
Show resolved
Hide resolved
antoniivanov
force-pushed
the
person/aivanov/vdk-core-log
branch
from
3c09a77
to
c11f3a1
Compare
gageorgiev
approved these changes
Sep 6, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/config/log_config.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/config/log_config.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/config/log_config.py
Outdated
Show resolved
Hide resolved
To enable users to override logs per module, temporarily (e.g for debugging or prototyping reasons to increase verbosity of certian module). The feature works similar to how spring level is specified (-Dlogging.level.com.baeldung=TRACE) Configruation is: 'log_level_module="my.module=INFO,my.second.module=debug"' Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
…config.py Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
…config.py Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
…config.py Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-core-log
branch
from
800a1eb
to
6bc1fa1
Compare
antoniivanov
commented
Sep 12, 2022
antoniivanov
added a commit
that referenced
this pull request
Sep 12, 2022
* vdk-core: add new configuration log_level_module To enable users to override logs per module, temporarily (e.g for debugging or prototyping reasons to increase verbosity of certian module). The feature works similar to how spring level is specified (-Dlogging.level.com.baeldung=TRACE) Configruation is: 'log_level_module="my.module=INFO,my.second.module=debug"' Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com> vdk-core: extend classification error test There are a few more test scenarios that are not covered but are pretty common and so we are adding them now. Testing Done: functional tests. Signed-off-by: Antoni Ivanov <aivanov@vmware.com> vdk-core: fix imports Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable users to override logs per module, temporarily (e.g for
debugging or prototyping reasons to increase verbosity of certian
module).
The feature works similar to how spring level is specified
(-Dlogging.level.com.baeldung=TRACE)
Configruation is:
'log_level_module="my.module=INFO,my.second.module=debug"'
Testing Done: unit tests
Signed-off-by: Antoni Ivanov aivanov@vmware.com