vdk-core: fix error classification of vdk code #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-core-err
branch
from
642b09b
to
30395e6
Compare
doks5
approved these changes
Sep 5, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/run/file_based_step.py
Show resolved
Hide resolved
antoniivanov
force-pushed
the
person/aivanov/vdk-core-err
branch
4 times, most recently
from
91ebdd9
to
a0bd54b
Compare
In case the User code is indirectly responsible (yet closest to the error in the stack trace), for example using a dependency incorrectly, the error cause (vdk, or user code) is not recognized correctly. See more details in #1118 and #580 Testing Done: added functional test covering the scenario Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-core-err
branch
from
a0bd54b
to
95bd2b5
Compare
antoniivanov
added a commit
that referenced
this pull request
Sep 8, 2022
With the change in #1173 this caused the classificatin not to work properly. Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
added a commit
that referenced
this pull request
Sep 8, 2022
With the change in #1173 this caused the classificatin not to work properly. Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
added a commit
that referenced
this pull request
Sep 8, 2022
With the change in #1173 this caused the classificatin not to work properly. Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
added a commit
that referenced
this pull request
Sep 8, 2022
With the change in #1173 this caused the classificatin not to work properly. Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the User code is indirectly responsible (yet closest to the
error in the stack trace), for example using a dependency incorrectly,
the error cause (vdk, or user code) is not recognized correctly.
See more details in #1118 and #580
Testing Done: added functional test covering the scenario
Signed-off-by: Antoni Ivanov aivanov@vmware.com