vdk-core: avoid circular references in print results #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's a circular reference in the data printed by execution_results, json.dumps will fail. So we are failing back to pprint which can handle them. pprint would sort the keys for us which leads to more confusing message (e.g the name of the stpe is not first for each step, etc.) That's why we are not using it by default. Sorting can be disabled but only from 3.8+ Testing Done: extended unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
gageorgiev
approved these changes
Sep 7, 2022
projects/vdk-core/tests/vdk/internal/builtin_plugins/run/test_execution_results.py
Outdated
Show resolved
Hide resolved
…execution_results.py Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a circular reference in the data printed by execution_results, json.dumps will fail.
So we are failing back to pprint which can handle them.
pprint would sort the keys for us which leads to more confusing message (e.g the name of the stpe is not first for each step, etc.) That's why we are not using it by default.
Sorting can be disabled but only from 3.8+
Testing Done: extended unit tests
Signed-off-by: Antoni Ivanov aivanov@vmware.com