vdk-core: fix flakey test in test checking logs output #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1177. Signed-off-by: murphp15 murphp15@tcd.ie
ivakoleva
approved these changes
Sep 27, 2022
|
closes #1177. |
antoniivanov
pushed a commit
that referenced
this pull request
Sep 29, 2022
closes #1177. Signed-off-by: murphp15 murphp15@tcd.ie Signed-off-by: murphp15 murphp15@tcd.ie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We want to fix intermittent failures in tests. Specifically the described in #1177.
What?
The underlying issue was that
test_log_pluginwas modifying the log level to warning.the test
test_run_dbapi_connection_no_such_db_typerelies on it being INFO to pass.There are two fixes to prevent this in the future
test_run_dbapi_connection_no_such_db_type.test_log_pluginwe revert the start back to info at the end of it.How has this been tested?
Before my fix I was getting an error reasonably frequently during runs.
After I added my fix in I ran the pipeline many more times and never encountered the error again.
What type of change are you making?
Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement
Signed-off-by: murphp15 murphp15@tcd.ie