vdk-core: Add log before query result fetch #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, vdk may indicate that a query execution took 10 or 20 minutes, even though the DB back shows that the query was actually executes in seconds. This results in the DB backend issuing a timeout error and a job failure. Because it happens sporadically, it is hard to reproduce and debug locally. This change adds a log message just before the result of a query is fetched, and should help better understand at which step the query execution hanged. Testing done: Documentation change. Signed-off-by: Andon Andonov <andonova@vmware.com>
gageorgiev
approved these changes
Sep 28, 2022
antoniivanov
pushed a commit
that referenced
this pull request
Sep 29, 2022
Occasionally, vdk may indicate that a query execution took 10 or 20 minutes, even though the DB back shows that the query was actually executes in seconds. This results in the DB backend issuing a timeout error and a job failure. Because it happens sporadically, it is hard to reproduce and debug locally. This change adds a log message just before the result of a query is fetched, and should help better understand at which step the query execution hanged. Testing done: Documentation change. Signed-off-by: Andon Andonov <andonova@vmware.com> Signed-off-by: Andon Andonov <andonova@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, vdk may indicate that a query execution took 10 or 20 minutes, even though the DB back shows that the query was actually executes in seconds. This results in the DB backend issuing a timeout error and a job failure. Because it happens sporadically, it is hard to reproduce and debug locally.
This change adds a log message just before the result of a query is fetched, and should help better understand at which step the query execution hanged.
Testing done: Documentation change.
Signed-off-by: Andon Andonov andonova@vmware.com