control-service: fix integration tests #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amazon EKS uses the aws eks get-token command, available in version 1.16.156 or later Latest changes in Kubernetes have broken our KUBECONFIG which uses older version of API resource and we get errors like "invalid apiVersion "client.authentication.k8s.io/v1alpha1" I am upgrading everything I see around to try to fix it. I have also regenerated the KUBECONFIG and updated in Gitlab CI Variables (using https://aws.amazon.com/premiumsupport/knowledge-center /eks-generate-kubeconfig-file-for-cluster/) Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
murphp15
approved these changes
Oct 5, 2022
antoniivanov
added a commit
that referenced
this pull request
Oct 6, 2022
Same change as in #1211 Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
ivakoleva
reviewed
Oct 6, 2022
| @@ -27,11 +27,8 @@ | |||
| variables: | |||
| _JAVA_OPTIONS: "-Xms2048m -Xmx4096m" | |||
| before_script: | |||
| - apk --no-cache add git openjdk11-jdk curl --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community | |||
| - curl -o aws-iam-authenticator https://amazon-eks.s3.us-west-2.amazonaws.com/1.21.2/2021-07-05/bin/linux/amd64/aws-iam-authenticator | |||
| - chmod +x ./aws-iam-authenticator | |||
There was a problem hiding this comment.
Amazon EKS uses the aws eks get-token command, available in version 1.16.156 or later. Until now we used aws-iam-authenticator but it seems latest changes in Kubernetes do not work there.
Could you link the official docs used in terms of aws-iam-authenticator changes required? For traceability on what has changed, and how
There was a problem hiding this comment.
They are linked in the PR. All the context I have is in aws/aws-cli#6920
I am not 100% sure why it happened now.
I decided to fix it by upgrading the KUBECONFIG and the way its used following https://docs.aws.amazon.com/eks/latest/userguide/create-kubeconfig.html
antoniivanov
added a commit
that referenced
this pull request
Oct 7, 2022
Same change as in #1211 Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest changes in Kubernetes have broken our KUBECONFIG which uses older version of API resource and we get errors like "invalid apiVersion "client.authentication.k8s.io/v1alpha1" (similar to aws/aws-cli#6920)
I am upgrading things around to fix it.
Amazon EKS uses the
aws eks get-tokencommand, available in version 1.16.156 or later. Until now we used aws-iam-authenticator but it seems latest changes in Kubernetes do not work there.I have also regenerated the KUBECONFIG and updated in Gitlab CI Variables (using https://docs.aws.amazon.com/eks/latest/userguide/create-kubeconfig.html)
Signed-off-by: Antoni Ivanov aivanov@vmware.com