vdk-pipeline-control-service: upgrade java client k8s version #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
changed the title
ivakoleva
approved these changes
Oct 5, 2022
projects/control-service/projects/versions-of-external-dependencies.gradle
Show resolved
Hide resolved
antoniivanov
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
I upgraded java client k8s version when trying to fix an issue related to connecting to the k8s cluster.
This was ultimately not the fix that was needed. But considering the work is done I think it make sense to merge it regardless.
What?
Upgrade the version in gradle and make a few small code changes to support the new apis.
How has this been tested?
Unit tests, integration tests but no new tests have been added
What type of change are you making?
Upgrade the version in gradle and make a few small code changes to support the new apis.
Signed-off-by: murphp15 murphp15@tcd.ie