vdk-pipeline-control-service: improve docs and local runability of integration tests #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration tests Signed-off-by: murphp15 <murphp15@tcd.ie>
ivakoleva
reviewed
Oct 5, 2022
projects/control-service/projects/pipelines_control_service/src/integration-test/README.md
Outdated
Show resolved
Hide resolved
projects/control-service/projects/pipelines_control_service/src/integration-test/README.md
Outdated
Show resolved
Hide resolved
...rojects/pipelines_control_service/src/integration-test/resources/application-test.properties
Outdated
Show resolved
Hide resolved
...rojects/pipelines_control_service/src/integration-test/resources/application-test.properties
Show resolved
Hide resolved
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
for more information, see https://pre-commit.ci
ivakoleva
approved these changes
Oct 5, 2022
...rojects/pipelines_control_service/src/integration-test/resources/application-test.properties
Outdated
Show resolved
Hide resolved
gageorgiev
approved these changes
Oct 5, 2022
antoniivanov
approved these changes
Oct 5, 2022
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
… flaxey tests. Signed-off-by: murphp15 <murphp15@tcd.ie>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When I tried to run the integration tests locally I experienced a number of issues.
I have updated the docs and configuration to make it much quicker to get the tests running locally.
What?
I added the property
I also improved the docs and make more defaults in the test configuration file.
How has this been tested?
integration tests. No extra tests added
What type of change are you making?
small changes to docs and also change to the configuration file for tests to give more sensible defaults
Signed-off-by: murphp15 murphp15@tcd.ie